Feature #33

« Previous | 8 of 267 | Next »

bad assumption that time_t is 32b

Added by vl almost 7 years ago. Updated almost 5 years ago.

Status:New Start date:09/03/2008
Priority:High Due date:
Assignee:sfb % Done:

0%
Category:-
Target version:-

Description

time_t can be 64 bits but in NeL we suppose that time_t is 32b and there's code that convert or store time_t under a uint32.

uint32 CTime::getSecondsSince1970 () {
return uint32(time(NULL));
}

The function must returns a time_t and check all linked issues.
To test, you can returning a uint64 and it'll generate warning where problems occur

Feature__33.patch (24.8 kB) Magnifier abelgar, 01/28/2009 11:24 pm

Feature__33_v2.patch (11.8 kB) Magnifier abelgar, 01/29/2009 11:39 am

History

#1 Updated by abelgar over 6 years ago

Here, a small patch which corrects the bad assumption. All linked issues has been corrected.

#2 Updated by abelgar over 6 years ago

clean version with add of an omission

#3 Updated by sfb about 6 years ago

  • Category set to Misc
  • Assignee set to sfb
  • Target version set to Version 0.7.0

#4 Updated by sfb almost 6 years ago

  • Priority changed from Normal to High
  • Target version changed from Version 0.7.0 to 0.8.0

So this is going to take some focus and testing, I'm changing the priority and moving it to 0.8.0 with hopes that it'll get fixed in trunk early in the 0.8.0 development cycle.

#5 Updated by kervala almost 5 years ago

  • Project changed from NeL to Ryzom
  • Category deleted (Misc)
  • Target version deleted (0.8.0)

Also available in: Atom PDF