Bug #1063

Alt+F4 should prompt for confirm exit

Added by Naush about 8 years ago. Updated almost 8 years ago.

Status:Assigned Start date:08/05/2010
Priority:Normal Due date:
Assignee:kervala % Done:

50%

Category:OS: GNU/Linux
Target version:-

Description

Actually if you use ALFT+F4 it's will crash the client, with a random backtrace. It's should prompt for exit instead.

1063-nel.patch (1.7 kB) Magnifier Naush, 10/09/2010 06:56 pm

1063-client.patch (9.4 kB) Magnifier Naush, 10/09/2010 06:56 pm

History

#1 Updated by kervala about 8 years ago

  • Status changed from New to Validated

Yes, close X event should be intercepted in event loop and processed by NeL :)

#2 Updated by Naush almost 8 years ago

1063-nel.patch: Activate and catch X11_destroy_window event.

NOTE: It will not change any things, code is missing in client/src/events_listener.cpp
As I don't really like the refuse to quit style of the official client, I have implemented my own, for fun. All close box are now asking for confirmation.

#3 Updated by kervala almost 8 years ago

Thanks a lot for your patches :) I will check and apply them if they are working.

About NeL part, if I remember right ClientMessage doesn't implies that window should be closed, there are other messages types which are using ClientMessage event.

We need also to send CEventDestroyWindow for Windows and Mac OS :)

#4 Updated by kervala almost 8 years ago

  • Priority changed from Low to Normal
  • % Done changed from 0 to 50

The NeL part has been applied (and fixed :p), so when closing a windows, Ryzom is now exiting properly :)

Thanks for the patch :)

#5 Updated by kervala almost 8 years ago

  • Status changed from Validated to Assigned
  • Assignee set to kervala

Also available in: Atom PDF