Ryzom

When multiple CGDMouseMove's are received in 1 frame, all previous CGDMouseMove's are discarded.
Bug is most visible on very high (1000HZ) sample rates. Lower framerate also increases the visibility of this bug.

Note: From time to time I explain things poorly, if so, ask, and I will explain it in a different fashion.
Also recommend your read the patch and source code, this will clear up a lot.

What happens:
Bug 1 (This only affected non-mouse-smoothed players):
In this code _MouseDeltaAX is set to _MouseDeltaAX = x * ClientCfg.FreeLookSpeed;
It should however be _MouseDeltaAX += x * ClientCfg.FreeLookSpeed;
Bug 2 (Affecting all):
if (fabs(_MouseDeltaAX) > epsilon) is used both to set and UNSET _MouseAngleX.
As a result, a subsequent update of a mouse-move of (X=0,Y=1) would reset the fact that X moved.
Bug 3 (Affecting all):
CEventsListener::getMouseAngleY() doesn't reset the delta angle.
This in combination with bugfix-1 would result in an ever-increasing delta.
Possible bug 4:
CUnixEventEmitter::emulateMouseRawMod might be called to often then required.
As a result it's not always sane to flush the XEvents.

Suggestion 1:
I also recommentdropping isMouseAngleY/X and only using getMouseAngleX/Y then detect float == 0 on that. (If this always works.)
(No risk of floating point errors (at least I think), because it will always be reset after reading the to-proccess-angle.)

Suggestion 2: (Topping Suggestion 1)
Move the check "if (fabs(_MouseDeltaAX) > epsilon)" CEventsListener::updateFreeLookPos to EventsListener::isMouseAngleX
This way it's only ran ONCE instead of every time :)
(This also removed the entire suggestion 1 in a cleaner fashion.)

Note 1:
In the current state of affairs, you MUST call getMouseAngleX after isMouseAngleX to keep a sane state.

Note 2:
This should also be fixed for CEventsListener::updateCursorPos ... this suffers from the same bugs, but this isn't too bad. (No bad effects.)

If suggestions and notes are accepted, I will also make a fix for those if you desire.