Feature #1458

Patcher on Linux/OSX

Added by Botanic over 6 years ago. Updated over 4 years ago.

Status:Resolved Start date:04/09/2012
Priority:Normal Due date:
Assignee:sfb % Done:

100%

Category:Client: General
Target version:Version 0.9.0

Description

This is a patch to enable patching on linux/osx

Linux is fully tested, osx...not (but it should work...)

hg.zip (7 kB) Botanic, 04/09/2012 09:04 pm

2308.patch (5.7 kB) Magnifier Botanic, 07/19/2012 02:06 am

History

#1 Updated by sfb over 6 years ago

  • Category set to Client: General
  • Assignee set to sfb
  • Target version set to Version 0.9.0

I'll go through and apply these.

#2 Updated by kervala over 6 years ago

First, thanks for the patch :) I have some comments about it.

There is no conditional patcher and it'll be enabled for all builds so it won't work anymore with Ryzom Core shards (there is no patch system enabled by default). Another problem with this patch is that if data are updated under Linux and Mac OS X, binaries won't be patched (because only Windows client is updated via the patch) and so, client might crash (or bug) if it's not compatible with last data.

I suggest to either add a CMake flag to enable and disable patcher or make further tests in code to check if a patch server is working. Another fix could be to define what data versions are compatible with what versions of client but it's too much work for little benefices.

I'm thinking about a variable set to last version for gamedev.bnp or the data of the last patch in default_client.cfg. If the current version of gamedev.bnp or the date of last patch is lower than it, we can enable patch of data. So we'll able to update data only if binary and default config are patched by packaging system.

#3 Updated by Botanic about 6 years ago

combined patch

#4 Updated by kervala over 4 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Fixed in compatibility branch :p

Also available in: Atom PDF