Bug #870
Ryzom client include private NeL headers
| Status: | Closed | Start date: | 05/10/2010 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  sfb |
% Done: | 100% |
|
| Category: | Build | |||
| Target version: | Version 0.8.0 |
Description
In client/src/sound_manager.cpp, Ryzom client includes private NeL headers (src/sound/clustered_sound.h and src/sound/audio_mixer_user.h).
This is wrong as only public headers should be included.
So, either those headers (or at least the functions used by Ryzom client) should be made public, either Ryzom client should be changed to use the already public ones (but without looking at them, I don't think they cover what is needed by Ryzom client).
History
#1
Updated by kervala over 8 years ago
Yes, you're right :) And when we install "headers", Ryzom should only use "installed headers" not private ones.
We already did that for NL3D (some .h files were in "src").
#2
Updated by sfb over 8 years ago
fyi I have most of this done in a personal repo. It's a lot so I won't get it pushed back until tomorrow. I might branch and push the branch back.
#3
Updated by sfb over 8 years ago
- Category set to Build
- Assignee set to sfb
#4
Updated by kervala over 8 years ago
Thanks sfb :)
#5
Updated by kervala over 8 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
#6
Updated by vl about 8 years ago
- Status changed from Resolved to Closed