Bug #884

24bpp support

Added by ThibG over 8 years ago. Updated about 8 years ago.

Status:Closed Start date:05/11/2010
Priority:Normal Due date:
Assignee:kervala % Done:

100%
Category:NeL: General
Target version:Version 0.8.0

Description

Hi, the OpenGL driver only supports 32bpp and 16bpp pixel formats.
Here is a patch to fix that.

24bpp.patch (1022 Bytes) Magnifier ThibG, 05/11/2010 08:18 pm

32bpp-24bpp.patch (1.4 kB) Magnifier ThibG, 05/12/2010 05:56 pm

History

#1 Updated by kervala over 8 years ago

  • Status changed from New to Assigned
  • Assignee set to kervala

#2 Updated by kervala over 8 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r111.

#3 Updated by kervala over 8 years ago

  • Target version set to Version 0.8.0

Thanks for the patch :)

#4 Updated by ThibG over 8 years ago

Seems my patch wasn't enough.
Here is what happen with the current version: glXChooseVisual accepts sAttribList32bpp despite running on a 24bpp only display, and fails when creating the window.
I think sAttribList32bpp is wrong by saying its depth is 24bpp. At least, on my computer, and maskow's (using a 24bpp-only driver too), it works.
However, I didn't do much X/GL stuff, so, I'm not that sure.

#5 Updated by sfb over 8 years ago

  • Status changed from Resolved to New

ThibG has additional patching required for this issue.

#6 Updated by kervala over 8 years ago

  • Status changed from New to Resolved

Applied in changeset r125.

#7 Updated by vl about 8 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF